Change exchange amount validator to use regex#1517
Merged
mrvisscher merged 2 commits intoLCA-ActivityBrowser:majorfrom Sep 9, 2025
Merged
Change exchange amount validator to use regex#1517mrvisscher merged 2 commits intoLCA-ActivityBrowser:majorfrom
mrvisscher merged 2 commits intoLCA-ActivityBrowser:majorfrom
Conversation
Member
|
LGTM but perhaps try to break my extra commit |
Collaborator
Author
|
Seems to work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the exchange amount validator to use regex. This allows copy and pasting from e.g. excel. Something the standard QDoubleValidator does not allow.
Checklist
./activity_browser/docs/wikiIf you have write access (otherwise a maintainer will do this for you):
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog.