Skip to content

Change exchange amount validator to use regex#1517

Merged
mrvisscher merged 2 commits intoLCA-ActivityBrowser:majorfrom
mrvisscher:major-validation-by-regex
Sep 9, 2025
Merged

Change exchange amount validator to use regex#1517
mrvisscher merged 2 commits intoLCA-ActivityBrowser:majorfrom
mrvisscher:major-validation-by-regex

Conversation

@mrvisscher
Copy link
Copy Markdown
Collaborator

@mrvisscher mrvisscher commented Sep 3, 2025

Changes the exchange amount validator to use regex. This allows copy and pasting from e.g. excel. Something the standard QDoubleValidator does not allow.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher requested a review from marc-vdm September 3, 2025 07:10
@mrvisscher mrvisscher added this to the 3.0.0 milestone Sep 3, 2025
@mrvisscher mrvisscher added the beta Issues related to the Activity Browser 3 Beta label Sep 3, 2025
@marc-vdm
Copy link
Copy Markdown
Member

marc-vdm commented Sep 3, 2025

LGTM but perhaps try to break my extra commit

@mrvisscher
Copy link
Copy Markdown
Collaborator Author

Seems to work!

@mrvisscher mrvisscher merged commit c715ec9 into LCA-ActivityBrowser:major Sep 9, 2025
0 of 12 checks passed
@mrvisscher mrvisscher deleted the major-validation-by-regex branch October 23, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta Issues related to the Activity Browser 3 Beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants